Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debug Builds #341

Merged
merged 1 commit into from
Jul 13, 2013
Merged

Fix Debug Builds #341

merged 1 commit into from
Jul 13, 2013

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Jul 13, 2013

Bump cmake minimum version to 2.8.11.2. This "fixes" the Debug build crashes in pyOutputRedirector, which were apparently caused by a flaw in cmake that was exposed by #337.

zrax added a commit that referenced this pull request Jul 13, 2013
@zrax zrax merged commit 509bf10 into H-uru:master Jul 13, 2013
@Mystler
Copy link
Contributor

Mystler commented Jul 14, 2013

As I already pointed out in the IRC channel, this bug seems to be fixed by the following CMake commit:
Kitware/CMake@c4bcc56

Obviously, this is a caching issue (FindPythonLibs uses SelectLibraryConfiguration). Have you tried deleting the cache?

@Hoikas
Copy link
Member Author

Hoikas commented Jul 16, 2013

I didn't try that. The cmake cache for CWE is sufficiently annoying to generate that I would be annoyed if someone told me to delete it to fix a bug :/

@Hoikas Hoikas deleted the fix-debug branch July 16, 2013 02:30
@Mystler
Copy link
Contributor

Mystler commented Jul 16, 2013

I'm not sure if it's enough to simply delete the PYTHON_* variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants