Only try to find the Max SDK if it was requested #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,8 +7,14 @@ if(PLASMA_BUILD_TOOLS) | |||
| endif() | |||
| endif() | |||
|
|
|||
| option(3dsm_BUILD_PLUGIN "Do we want to build the 3ds Max plugin?" OFF) | |||
| if (3dsm_BUILD_PLUGIN) | |||
There was a problem hiding this comment.
Why did you add that if condition here if the same one comes right after it again?
… to try to build it always)
|
👍 |
dpogue
added a commit
that referenced
this pull request
Apr 18, 2014
Only try to find the Max SDK if it was requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we look for the Max SDK, and then show an option (disabled by default) to build the plugin only if it was found. This is backwards from how most CMake projects work, so this PR reverses that to allow the user to enable it first, and then require the SDK when they enable it.