plFormat: a type-safe string formatter #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #define BADCHAR_REPLACEMENT (0xFFFDul) | ||
|
|
||
| namespace plFormat_Private |
There was a problem hiding this comment.
What's the point of namespacing everything if it's marked as file-static anyway?
There was a problem hiding this comment.
ah, nvm. It's not all static. Carry on
|
Added better documentation, and converted to doxygen format |
|
👍 |
| { | ||
| hsAssert(*(ptr + 1), "Unterminated format specifier"); | ||
| char *end = nullptr; | ||
| spec.fPrecisionLeft = strtol(ptr + 1, &end, 10); |
There was a problem hiding this comment.
Shouldn't this be fPrecisionRight?
|
Something seems super funky about floating point precision specifiers, just reading through the code |
Hoikas
added a commit
that referenced
this pull request
May 21, 2014
plFormat: a type-safe string formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who wants to type
plString::Format("%-8s", filename.AsString().c_str())when you can typeplFormat("{<8}", filename)instead? :)