Some cross-platform code cleanups. #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,13 +119,13 @@ void ErrorAssert(int line, const char* file, const char* fmt, ...) | |||
| va_list args; | |||
| va_start(args, fmt); | |||
| vsnprintf(msg, arrsize(msg), fmt, args); | |||
| #ifdef HS_DEBUGGING | |||
| #ifdef _MSC_VER | |||
There was a problem hiding this comment.
Checking if something is compiled on MSVC is not the same as checking whether debugging is enabled... I'm not quire sure I understand what this change is supposed to be doing
There was a problem hiding this comment.
Two lines above the diff is #if defined(HS_DEBUGGING) || !defined(PLASMA_EXTERNAL_RELEASE)
There was a problem hiding this comment.
This is not correct. Building an Internal client now leads to the call of _CrtDbgReport in Line 125. However, that function is not defined when not building in Debug mode and we get a compiler error.
|
This has been updated to address the HS_DEBUGGING problems. |
| @@ -325,7 +325,10 @@ uint32_t plSecureStream::IRead(uint32_t bytes, void* buffer) | |||
| } | |||
| else | |||
| { | |||
| // TODO: errno equivalent for *nix | |||
zrax
added a commit
that referenced
this pull request
Feb 14, 2015
Some cross-platform code cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for MinGW and clang with HS_DEBUGGING enabled.