OSX fixes #494
Merged
OSX fixes #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Same story for expat | ||
| option(EXPAT_IS_STATIC "Using the static version of libexpat" ON) | ||
| if(WIN32) |
There was a problem hiding this comment.
If you read the commit message, the CURL_IS_STATIC and EXPAT_IS_STATIC flags are meaningless outside of WIN32 (i.e. they only control whether to use __declspec(dllimport) / __declspec(dllexport)). I discovered that I've been leaving them set to the default (ON) for ages even though my system libs are not static.
|
Seems fine to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make everything build on Mac yet, but it at least gets the tools and tests fully building, and gets a bit further along with the rest.