Exception stuff #511
Merged
Exception stuff #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| else | ||
| { | ||
| printf("Something bad happened while reading SDLMgr data: %s", e.what()); |
| @@ -130,6 +130,22 @@ typedef int32_t hsError; | |||
| # define hsDeprecated(message) | |||
| #endif | |||
|
|
|||
| #ifdef HAVE_OVERRIDE | |||
| # define HS_OVERRIDE override | |||
There was a problem hiding this comment.
This has been around since MSVC++2012. Do we actually have to test for it?
There was a problem hiding this comment.
We've specified our minimum MSVC compiler, but I don't know what we're targetting for GCC now that it has better support. IIRC, GCC only added override/final in version 4.7. I'm fine with making GCC 4.7 the minimum version though and cleaning this up :)
FYI, this minimum would exclude Ubuntu 12.04 LTS -- a distro I've usually still tried to support with libhsplasma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of some exception information where it was previously being ignored, and derives HeadSpin exceptions from
std::exception. It also adds compiler feature detection fornoexcept,override, andfinal, and makes use ofnoexceptin a few places where it may be useful (mostly the hsExceptions and plString)