Use hsThread for SoundBuffer preloading. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears you adjusted the file (or at least your additions) to use 2-space indentations... >.> |
|
Those are tabs actually... blame Visual Studio (and then blame github for On Tue, Jun 28, 2011 at 17:07, zrax <
|
| if(buffer->GetData()) | ||
| for (int i = templist.GetCount(); i > 0; i--) | ||
| { | ||
| plSoundBuffer* buf = templist.Pop(); |
There was a problem hiding this comment.
It seems you're tracking the list contents twice here (once with the decrementing index and once by actually popping an item)... Why not just throw away the for loop and use "while (templist.GetCount())" or something along those lines?
Deledrius
added a commit
that referenced
this pull request
Jul 23, 2011
Use hsThread for SoundBuffer preloading.
Deledrius
added a commit
to Deledrius/Plasma
that referenced
this pull request
Dec 4, 2012
Use hsThread for SoundBuffer preloading.
Hoikas
pushed a commit
to Hoikas/Plasma
that referenced
this pull request
Dec 4, 2012
Use hsThread for SoundBuffer preloading.
Hoikas
pushed a commit
to Hoikas/Plasma
that referenced
this pull request
Dec 13, 2012
Use hsThread for SoundBuffer preloading.
zrax
pushed a commit
to zrax/Plasma
that referenced
this pull request
Apr 24, 2020
Fix Zandi Welcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than relying on non-portable CCritSect and pnUtils stuff, use existing hsThread classes for plSoundBuffer preloading.
As a side note, I don't know if this code ever worked, since the buffer was never removed from the original list when being added to the templist... I think that would be an infinite loop >.>