WIP: plCreatable modernizing #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Due to the massive application of |
|
oops, I either forgot about HS_OVERRIDE or it was added shortly after I started this. I'm happy to use HS_OVERRIDE if that's our intention. |
|
Did we ever figure out what needed to happen here? |
|
Going to update it to use |
* Use nullptr instead of nil * Use static_casts where applicable * Mark virtual methods in subclasses as override
|
Updated to use HS_OVERRIDE. |
| return (plClassName*)plFactory::Create(plClassName##ClassIndex); \ | ||
| #define CLASSNAME_REGISTER(plClassName) \ | ||
| public: \ | ||
| const char* ClassName() const override { \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just changing the creatable macros to properly use C++-style casts, and the creatable types to use the
overridekeyword properly.I started in NucleusLib, and then got distracted with investigating some of the old plKey loading stuff. Eventually we'll want all creatable classes in all libs to properly use
override.Clang (and gcc) warn about missing overrides, so the goal is to have no override warnings.