Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String theory port #529

Merged
merged 14 commits into from Jan 7, 2017
Merged

String theory port #529

merged 14 commits into from Jan 7, 2017

Conversation

zrax
Copy link
Member

@zrax zrax commented Apr 11, 2016

Port to string_theory string library. Depends on #528.

@zrax
Copy link
Member Author

zrax commented Apr 11, 2016

Also makes #526 irrelevant

@zrax zrax mentioned this pull request Apr 13, 2016
Closed
@Hoikas
Copy link
Member

Hoikas commented Jun 19, 2016

Did we ever get a fix for the debug vs release library issues on MSVC?

@zrax
Copy link
Member Author

zrax commented Jun 21, 2016

No, not yet... I haven't decided yet whether to fix it by using different naming (like Python or Qt) to allow them to install side-by-side, or just including two different builds on Windows only... I'd really like to avoid moving everything out of inlines though, since that defeats a lot of the optimization potential.

@Hoikas
Copy link
Member

Hoikas commented Jun 21, 2016

Agreed. I think I would go the Python/Qt route since that's a fairly common practice.

@zrax
Copy link
Member Author

zrax commented Jun 21, 2016

Ok, string_theory 1.1 should fix the library issue.

@Hoikas
Copy link
Member

Hoikas commented Jun 22, 2016

The readme should probably be updated to mention string_theory 1.1

@Hoikas
Copy link
Member

Hoikas commented Jun 24, 2016

On play testing, I encountered a bug in which the books on the Relto bookshelf are nonfunctional. This issue does not occur in the latest commit on master.

Hoikas and others added 3 commits December 28, 2016 20:32
@Hoikas
Fix crashing in fragile module name handling code
39b7840
@Hoikas
Fix ptKey.getName() returning empty strings
b91f1b7 
I hope this does not mean we have to audit the entire codebase for more
PyString_FromString calls...
@zrax
Merge pull request #6 from Hoikas/st_fixes
7f55003 
Fix Relto Issues
@Hoikas
Copy link
Member

Hoikas commented Dec 29, 2016

This gets a 👍 from me, but I would like to hear from one more play test before we merge.

@Deledrius Deledrius mentioned this pull request Jan 2, 2017
Closed
Hoikas and others added 2 commits January 4, 2017 22:44
@Hoikas
Fix a crash in plResponderModifier
ffcddae 
This crash was observed only in Debug mode. The Responder log would be
filled with garbage for reasons unknown to me--the release mode logs
would be fine. As an added bonus, this fixes an issue in which Cyan went
looking for the haystack inside the needle.
@zrax
Merge pull request #7 from Hoikas/st_fixes
ba6f91b 
Fix a crash in plResponderModifier
@Hoikas
Copy link
Member

Hoikas commented Jan 6, 2017

It's time to get off this pot. Any OHBjections to this pull request being merged should be voiced within the next 24-36 hours.

dpogue
dpogue approved these changes Jan 6, 2017
View reviewed changes
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to compile properly on Linux with clang and gcc and mingw, so I'll give that a 👍 from me

@Hoikas Hoikas merged commit 9450522 into H-uru:master Jan 7, 2017
@zrax zrax deleted the string_theory branch January 11, 2017 23:03
@Hoikas Hoikas mentioned this pull request May 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zrax @Hoikas @dpogue