Change PtDebugPrint to behave more like Py3 print.
#649
Conversation
| if (value) { | ||
| if (PyInt_Check(value)) | ||
| level = PyInt_AsLong(value); | ||
| else | ||
| break; | ||
| } | ||
|
|
||
| value = PyDict_GetItemString(kwargs, "sep"); |
There was a problem hiding this comment.
Bonus points: add end as well :)
print('Things: ', end='') # Elide newline
for thing in things:
print(thing, end=', ')
print() # Finish the lineThere was a problem hiding this comment.
Unfortunately, plStatusLog unconditionally treats each call to AddLine as at least one line. Fixing that is outside the scope of this PR, but I will add an end argument that allows terminating with an arbitrary string.
There was a problem hiding this comment.
Fair enough, but I'd rather not see end default to '\n' if we're going to end up writing two newlines (one from AddLine and one from the default end)... Maybe it would be better to just leave out the end parameter until it's needed (and then update the DebugPrint to use it properly at the same time)
There was a problem hiding this comment.
plStatusLog only adds the trailing \n if one is not present. I decided to default end to \n on the off chance that some later work allows eliding newlines in plStatusLog 😄
| PYTHON_RETURN_NONE; | ||
| } while (false); | ||
|
|
||
| // fell through to the type error case | ||
| PyErr_SetString(PyExc_TypeError, "PtDebugPrint expects a sequence of strings and an optional int"); | ||
| PyErr_SetString(PyExc_TypeError, "PtDebugPrint expects a sequence of strings, an optional int, and an optional string"); |
There was a problem hiding this comment.
kwargs are not "optional parameters", since they need to be explicitly keyed... Also, since we're str()ifying parameters (to match print), I feel like this message is misleading in multiple ways.
|
Updated to fix issues from review. |
| if (value) { | ||
| if (PyInt_Check(value)) | ||
| level = PyInt_AsLong(value); | ||
| else | ||
| break; | ||
| } | ||
|
|
||
| value = PyDict_GetItemString(kwargs, "sep"); |
There was a problem hiding this comment.
Fair enough, but I'd rather not see end default to '\n' if we're going to end up writing two newlines (one from AddLine and one from the default end)... Maybe it would be better to just leave out the end parameter until it's needed (and then update the DebugPrint to use it properly at the same time)
|
|
||
| value = PyDict_GetItemString(kwargs, "sep"); | ||
| if (value) { | ||
| if (PyString_CheckEx) |
There was a problem hiding this comment.
I think you're missing something here 
There was a problem hiding this comment.
Just making sure you're paying attention
This is to facilitate H-uru/moul-scripts#119.
PtDebugPrint()now outputs to a single line and accepts the keyword argumentsep, which functions in the same manner as Python 3's sep keyword argument.TheKnown limitation: theendkeyword argument was not added.endargument cannot be used to elide newlines.I have also fixed a memory leak in which the repr of a PyObject was not decref'd.