Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #705

Merged
merged 3 commits into from
Aug 30, 2020
Merged

Add CONTRIBUTING.md #705

merged 3 commits into from
Aug 30, 2020

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Aug 22, 2020

This adds CONTRIBUTING.md, which is considered a de-facto landing page for folks who are interested in contributing to the project. I'm not the best writer in the world, so comments and suggestions are definitely welcomed (and encouraged!). I suspect that it will be easier to read on the actual branch instead of as a diff 馃槈

@dpogue
Copy link
Member

dpogue commented Aug 22, 2020

I think a section on where to get in touch with active developers to discuss changes is a good idea. Probably include info on #writers IRC and the GoW forums? Maybe also a link to OU Discord?

@Hoikas
Copy link
Member Author

Hoikas commented Aug 22, 2020

I agree - where do you think that would best be added?

@dpogue
Copy link
Member

dpogue commented Aug 22, 2020

Maybe a "Getting Involved" section after the project goals?

@ghost
Copy link

ghost commented Aug 23, 2020

Double 'and' in "improving cross-platform and and compiler compatibility".

@Hoikas
Copy link
Member Author

Hoikas commented Aug 24, 2020

Fixed the grammar error pointed out by @aqua-uru.

@Hoikas Hoikas requested a review from Deledrius August 24, 2020 00:10
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Hoikas
Copy link
Member Author

Hoikas commented Aug 24, 2020

Updated to address review comments.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
- Clarify what a non-goal is
- Minor wording and formatting changes
@Hoikas
Copy link
Member Author

Hoikas commented Aug 24, 2020

Fixed missing punctuation.

@Hoikas Hoikas merged commit 007866b into H-uru:master Aug 30, 2020
@Hoikas Hoikas deleted the contrib branch August 30, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants