Add source groups for game scripts and associated files. #727
Conversation
| @@ -1,10 +1,20 @@ | |||
| file(GLOB_RECURSE GameScripts "${CMAKE_CURRENT_SOURCE_DIR}/Python/*.py") | |||
| file(GLOB_RECURSE GameSDL "${CMAKE_CURRENT_SOURCE_DIR}/SDL/*.sdl") | |||
| file(GLOB_RECURSE GameData "${CMAKE_CURRENT_SOURCE_DIR}/dat/*.age" "${CMAKE_CURRENT_SOURCE_DIR}/dat/*.fni") | |||
There was a problem hiding this comment.
I'm not suggesting you change anything, but please note that glob lists will only get updated when CMake is re-run... They will never get automatically updated when files are added or removed.
There was a problem hiding this comment.
I'm aware, and considered this. Since they aren't used as part of the build, I felt it was okay for that loophole to exist. The copy commands all will continue to work fully, so this won't affect any functionality, it only requires a re-run of CMake for the convenience of having them in the UI. As far as drawbacks go, it seemed acceptable.
There was a problem hiding this comment.
It's probably better to do any dedicated hacking on these files in a more filesystem driven editor, such as VS Code.
There was a problem hiding this comment.
I agree, but I've found myself wanting to pull them up several times for reference while working on engine code, and this makes it easier to do so. Also, it seemed odd to me in general to have a large collection of scripts and other text files being operated on by the build system but not available in the UI.
This makes it easier to find, browse, and edit the files now included in the recently-added Scripts project.