Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Cleanup #770

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Warning Cleanup #770

merged 5 commits into from
Jan 13, 2021

Conversation

zrax
Copy link
Member

@zrax zrax commented Jan 11, 2021

Greatly reduces the number of warnings (when enabled) for both GCC and MSVC builds.

@Hoikas
Copy link
Member

Hoikas commented Jan 11, 2021

I wonder if compilation times would be negatively affected on MSVC by simply dropping the #pragma hdrstops...

@zrax
Copy link
Member Author

zrax commented Jan 11, 2021

I wonder if compilation times would be negatively affected on MSVC by simply dropping the #pragma hdrstops...

On my machine (building in VC 2019 with msbuild /m:8 on an SSD), I see a clean build in ~3m50s with #pragma hdrstop and ~4m04s without it, so the difference is not significant for me. However, I don't know if the IDE builds in parallel by default, or how much different the results would be on a slower machine (or slower drives).

@Hoikas
Copy link
Member

Hoikas commented Jan 11, 2021

That seems acceptable to me - there are plenty of other low hanging build speedups available in header cleanups and unity builds.

@zrax zrax merged commit 1644f10 into H-uru:master Jan 13, 2021
@zrax zrax deleted the warnings branch January 13, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants