Cleanup NucleusLib linkage. #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXCEPT for pnNucleusInc, which has a lot of loops with other Nucleus-level targets. The easiest solution will probably be to remove it as a target and instead treat it as an include directory, somehow. This also fixes some problems with pnUtils leaking its PCH to the rest of the engine.
Original time: 6s, Now: 2s.
zrax
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More progress on #383...
This ensures that all NucleusLib targets except for pnNucelusInc have the correct target linkage established. While going through, I made much of the linkage private by moving includes from headers into source files, throwing away old code, and fixing the fallout along the way. pnNucleusInc will likely require some additional thought and planning, so I'm saving that for later.