More Build Time Improvements #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcperf says that the compiler is spending a lot of time parsing these headers (redundantly): - string_theory/string - string_theory/formatter - filesystem (included from string_theory)
zrax
reviewed
Feb 27, 2021
Co-authored-by: Michael Hansen <zrax0111@gmail.com>
This has never had a class index, according to the records in libHSPlasma.
zrax
reviewed
Feb 28, 2021
zrax
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another batch of build improvements by enabling unity builds and adding precompiled headers. With this round, I used
vcperfto profile what exactly MSVC was doing. According to profiling, the parsing ofst_string.handst_formatter.hare what we are spending the most time on, so the focus was primarily on adding precompiled headers including those files.Further profiling indicates the following future work is available:
windows.his leaking intoplDrawableandpfPythonviapnInputCore/plKeyDef.hPubUtilLibis building serially due to dependency spaghetti. The average build concurrency is 1.5 parallel targets, according to my profiling.As a bonus, enabling unity builds on
plSurfaceexposed that the creatableplLayerMultiplywas never registered nor did it ever have a class index. This has been corrected to fix linker errors.On my machine, the following improvements have been measured:
The above list is not intended to be comprehensive of the proposed changes. The full list of build timings before and after is attached. They were generated using this extension.