Fix #930. #940
Merged
Fix #930. #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zrax
reviewed
Jun 21, 2021
This fixes the issues resulting from Autodesk bolting on localization support and sanitizing certain words.
These proxies are a little fiddly, but I can't think of a better way to do it since the old overloads are now `MAX_SEALED` and proxy to the new overload. While we could undef `MAX_SEALED`, that assumes AD will never change `MAX_SEALED` to an outright `final`, so we'd be back to this same problem again.
|
Working on compile errors revealed by max plugin CI. |
In the Max 2008 lib files, `ReferenceTarget::GetClassName()` is exported as `ReferenceTarget::GetClassNameA()`. Later versions of Max undefine `GetClassName` to prevent that.
|
CI errors fixed. |
zrax
reviewed
Jul 2, 2021
Co-authored-by: Michael Hansen <zrax0111@gmail.com>
zrax
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.