Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci4ci test #406

Merged
merged 3 commits into from
Jul 22, 2024
Merged

ci4ci test #406

merged 3 commits into from
Jul 22, 2024

Conversation

kostyanf14
Copy link
Contributor

No description provided.

@kostyanf14 kostyanf14 changed the title ci4ci ci4ci test Jul 4, 2024
@kostyanf14
Copy link
Contributor Author

run tests

@kostyanf14
Copy link
Contributor Author

rerun tests

1 similar comment
@kostyanf14
Copy link
Contributor Author

rerun tests

@kostyanf14
Copy link
Contributor Author

run tests

2 similar comments
@kostyanf14
Copy link
Contributor Author

run tests

@kostyanf14
Copy link
Contributor Author

run tests

@kostyanf14
Copy link
Contributor Author

run tests

@kostyanf14
Copy link
Contributor Author

run tests

@kostyanf14
Copy link
Contributor Author

rerun tests

5 similar comments
@kostyanf14
Copy link
Contributor Author

rerun tests

@kostyanf14
Copy link
Contributor Author

rerun tests

@kostyanf14
Copy link
Contributor Author

rerun tests

@kostyanf14
Copy link
Contributor Author

rerun tests

@kostyanf14
Copy link
Contributor Author

rerun tests

@kostyanf14
Copy link
Contributor Author

rerun tests

Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names of files are awkward.
.ci shouldn't be prefixed with a dot; sometimes it is necessary to prefix a directory name with a dot like .github. This is because some development platforms misbehave when there are unexpected files and prefixing with a dot fixes them. We don't use such a development platform.

test_01.sh and test_02.sh are obscure names. Perhaps you may use driver names.

lib/project.rb Show resolved Hide resolved
.ci/test_01.sh Outdated Show resolved Hide resolved
.ci/test_01.sh Outdated Show resolved Hide resolved
lib/project.rb Show resolved Hide resolved
jenkins/test_igb.sh Outdated Show resolved Hide resolved
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
@kostyanf14 kostyanf14 merged commit 8344257 into HCK-CI:master Jul 22, 2024
9 checks passed
@kostyanf14 kostyanf14 deleted the ci4ci branch July 22, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants