Remove references to deprecated low_hi option for get_reds
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows HERA-Team/hera_cal#370 and shouldn't be merged in until that PR is done.
ghost
assigned 
|
(These tests pass locally on the |
jsdillon
changed the title
low_hi option for get_redslow_hi option for get_reds
|
HERA-Team/hera_cal#370 has been merged in and now we're ready for this PR |
1 similar comment
philbull
approved these changes
Oct 24, 2018
| @@ -34,7 +34,7 @@ install: | |||
| - conda info -a | |||
|
|
|||
| # create environment and install dependencies | |||
| - conda create -q -n test-environment python=$TRAVIS_PYTHON_VERSION numpy scipy nose pip matplotlib coverage | |||
| - conda create -q -n test-environment python=$TRAVIS_PYTHON_VERSION 'numpy <1.15.3' scipy nose pip matplotlib coverage | |||
There was a problem hiding this comment.
I am a little worried about pinning the version number of a major package like this, but if we have no choice...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows HERA-Team/hera_cal#370 and shouldn't be merged in until that PR is done.