-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pspecdata input calibration and pspec_run updates #212
Conversation
modified: pspecdata.py modified: tests/test_pspecdata.py modified: utils.py
@plaplant okay I added a print warning and updated a docstring in |
@nkern I think the way forward here is to run a check each time a new group or dataset would be added to a pspec file, and raise an error if the file is in SWMR mode. I agree that I don't want to hamstring the user too much, but also want to make sure that we're using the library correctly. (Re: the issue you posted yesterday, the library as currently written seems to be able to create datasets without error, but I am skeptical the data are actually being written correctly. Even if you showed it was not writing nonsense for a few datasets, I don't think we should be doing it at all because the library makes no guarantees to correctness, and places all responsibility on the user.) I think defaulting to |
@philbull @plaplant Okay, I've updated PspecContainer such that it will not write new groups or datasets if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor comments on docstrings and a query about whether to move some utility functions.
General updates in support of
H1C_IDR2
pipeline overhaul. This includes:• allows
PSpecData.add()
to take a calibration file and apply on-the-fly• new
interleave_times
kwarg topspec_run
• allow for
_load_dsets
to take multiple files for a single entry indsets
•
pspec_run
now only returnsds
instead ofpsc, ds
•
ds.validate_datasets
bug fix when doing auto-dset power spectra• optional SWMR mode in
PSpecContainer
• minor changes to
grouping.bootstrap_run
to incorporate PSpecContainer transactional mode