Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Distortion of None #379

Closed
3 tasks done
psavery opened this issue Jul 7, 2020 · 1 comment · Fixed by #415
Closed
3 tasks done

Fixes for Distortion of None #379

psavery opened this issue Jul 7, 2020 · 1 comment · Fixed by #415
Labels

Comments

@psavery
Copy link
Collaborator

psavery commented Jul 7, 2020

For LLNL, a distortion of None will most often be used. When the distortion is None, there shouldn't be parameters for the distortion function in the tree view. There will be a few things that need to be done.

  • Remove the distortion function parameters from the default instrument config, so they don't get set automatically when a config file is loaded
  • When the distortion is selected to be None via the form view (see below), remove the distortion parameters from the HexrdConfig instrument config, so they do not appear in the tree view
  • When the distortion is changed from None to something else, add distortion parameters to the HexrdConfig instrument config

It appears that the form view already hides the parameters when None is chosen for the distortion function, which is correct. Now, we'd just need to get it to remove the parameters from the internal instrument config, and then add them back in if if the user switches to a different distortion other than None.
distortion_none

This function might be useful for this.

@cjh1
Copy link
Collaborator

cjh1 commented Jul 7, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants