Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Evaluation #5

Open
AmingWu opened this issue Aug 14, 2024 · 7 comments
Open

About Evaluation #5

AmingWu opened this issue Aug 14, 2024 · 7 comments

Comments

@AmingWu
Copy link

AmingWu commented Aug 14, 2024

Dear Authors,

I have finished the training process. However, I cannot find the saved model.

Is the model saved in dump/0813-ZINC/scaffold-concept/params.pkl?

But when I run the command, these exists an error, i.e., python eval.py --dataset GOODZINC --domain scaffold --shift concept --load_path dump/0813-ZINC/scaffold-concept/params.pkl?

捕获

@toooooodo
Copy link
Collaborator

Hi, it seems that you have specified incorrect load_path, the correct path should be as specified in

def save_model(model, save_dir, epoch=None, model_name='model'):

@AmingWu
Copy link
Author

AmingWu commented Aug 14, 2024

During training, should I set --load_path ?

@toooooodo
Copy link
Collaborator

This is not required. This parameter is only needed for eval.py, and we provide the trained model in the release page.

@AmingWu
Copy link
Author

AmingWu commented Aug 14, 2024

Now, I want to re-train this code. I set the save_dir to 'checkpoint/'. Is it right?

@AmingWu
Copy link
Author

AmingWu commented Aug 14, 2024

Dear Authors,

When I finish the training, i.e., python run.py --dataset GOODZINC --domain scaffold --shift concept --num_e 4000 --bs 256 --gamma 0.5 --inv_w 0.01 --reg_w 0.5 --gpu 1 --exp_name ZINC --exp_id scaffold-concept

I still could not finish evaluation successfully.

@AmingWu
Copy link
Author

AmingWu commented Aug 14, 2024

Could you tell me where the trained model is? I use the default path.

@toooooodo
Copy link
Collaborator

Hello, I checked the code and found that the model was not being saved during training. You can call

def save_model(model, save_dir, epoch=None, model_name='model'):

in train.py to save the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants