Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJK justification does not work #169

Closed
ftake opened this issue Apr 30, 2016 · 11 comments
Closed

CJK justification does not work #169

ftake opened this issue Apr 30, 2016 · 11 comments

Comments

@ftake
Copy link

ftake commented Apr 30, 2016

CJK justification which was implemented in 1.5.0 does not work with CTL branch

Some spaces exist at the end of line.

Test data is attached to #143

@khaledhosny
Copy link

This is probably the same underlying issue as #170.

@khaledhosny
Copy link

I pushed a commit that should fix this, please test.

@ftake
Copy link
Author

ftake commented May 5, 2016

It looks working fine. Thanks!

@ftake ftake closed this as completed May 5, 2016
@Fahad-Alsaidi
Copy link
Contributor

I don't think it fixed completely see this screen shot:
cjk

@Fahad-Alsaidi Fahad-Alsaidi reopened this May 5, 2016
@ftake
Copy link
Author

ftake commented May 5, 2016

I guess the problem with the first line is caused by the rule that the space of "「" is removed.

The problem with the last line looks similar to justification problem of line that have new line (not new paragraph), which exists before 1.5.1.

@khaledhosny
Copy link

@Fahad-Alsaidi are you using regular or full justification in this screenshot?

@Fahad-Alsaidi
Copy link
Contributor

@khaledhosny full justification

@khaledhosny
Copy link

OK, so the last line is what I’d expect in full justification, the first line looks like a bug that needs to be investigated. Might be that the space we subtracted from “「” got added again.

khaledhosny added a commit that referenced this issue May 6, 2016
@khaledhosny
Copy link

This should be fixed now, please test.

@ftake
Copy link
Author

ftake commented May 6, 2016

looks good to me

@khaledhosny
Copy link

Thanks for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants