Fork at 257000 per Unforkening Nutocracy motion, #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://nutocracy.herokuapp.com/arguments/that-it-is-time-to-un-fork-hodlcoin-and-stop-auto-hodling-for-a-year Autohodling removed from block 257000 Older version clients disconnected after block 250000 Also, bug fix to ensure interest not earned on deposits after maturation period ends.
Fuzzbawls
reviewed
Apr 26, 2017
| @@ -11,6 +11,8 @@ | |||
| #include "serialize.h" | |||
| #include "uint256.h" | |||
|
|
|||
| static const unsigned int THEUNFORKENING = 257000; | |||
There was a problem hiding this comment.
seems like an odd place for this kind of constant as it not really a transaction primitive but a consensus rule
There was a problem hiding this comment.
Yeah, I initially had it in main.h, but found it was required in the interest calculation code here to fix the interest rate bug.
| @@ -9,7 +9,7 @@ | |||
| * network protocol versioning | |||
| */ | |||
|
|
|||
| static const int PROTOCOL_VERSION = 70010; | |||
| static const int PROTOCOL_VERSION = 250000; | |||
There was a problem hiding this comment.
is there a reason for such a massive jump in protocol version?
There was a problem hiding this comment.
I had previously thought that the version here was doubling as the block at which clients using the old code were disconnected.
Fuzzbawls
reviewed
Apr 26, 2017
| @@ -22,7 +22,7 @@ static const int MIN_PEER_PROTO_VERSION = GETHEADERS_VERSION; | |||
|
|
|||
| //! disconnect from peers once fork height reached | |||
| static const int MIN_PEER_PROTO_MINERHODLFORK_VERSION = 70010; | |||
|
|
|||
| static const int MIN_PEER_PROTO_THEUNFORKENING_VERSION = 250000; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nutocracy.herokuapp.com/arguments/that-it-is-time-to-un-fork-hodlcoin-and-stop-auto-hodling-for-a-year
Autohodling removed from block 257000
Older version clients disconnected after block 250000
Also, bug fix to ensure interest not earned on deposits after maturation period ends.