-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hopefully all things Nike asked for this weekend (ending 2 December 2018) #15
Comments
@szilardszalay , @nchancel , what do you guys think about the "+4" pegasus edges within single cells? Should they still be black? Or should they be blue (meaning ALL chimera edges are grey and ALL added pegasus edges are blue), or grey (meaning everything within a single layer z, is grey, and edges BETWEEN different layers are blue) ? |
If we are talking about 2(a) I can see either working, In 2(b) I think they should be a different colour which stands out, and the black works pretty well for that. |
Of course this is about 2a, because in 2b, blue is used for something very specific. |
Black is definitely too strong in fig 2(a). I would
|
Yes I have mixed feelings about all this, and I keep alternating about what I think would be best, so that's why I value your opinions here. On one hand, we wanted to emphasize the new edges in Pegasus, If we color based on chimera/pegasus, then the black edges would be light blue. I think this is okay, except that in Fig 2a and similar figures, we would have 6 colors (red/blue/green/orange/grey/light blue) instead of 5. Even if we made these edges black in Fig 2b, we might have to explain why there's 6 colors instead of 5. But the caption is already quite a fair size. If we color based on inter-layer/intra-layer, we would color these edges grey in both 2a and 2b, which I think is okay. However in the supplemental material, I like having the black edges for the single cell pegasus figures. This is something that can be done in the next commit (please make sure to pull from master first, so that you're editing the most recent version of the paper), however I think all three of us wouldn't mind submitting the paper without this change of color (it's a minor change that is not of very high priority.. it can be done at any time in the future and it doesn't change the scientific content of the paper). Higher priority would be to finish the SFR gadgets (derivations, gadget graphs, embeddings.... although embeddings will be taken care of by me and Alex). Also there's the RBS gadget graphs to make (1 for cubic, 2 for quartic) from the email I sent. |
Referring to version of: https://github.com/HPQC-LABS/Pegasus/blob/ec1fdcb07fd0f5a9c01faf32e7532b45333d1bdb/pegasus.pdf
No more further changes that I didn't ask for please. Not for now at least. Let me work on getting this paper to a submission-worthy stage because too much has changed since I last did that.
The text was updated successfully, but these errors were encountered: