Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebook social links #1142

Merged
merged 23 commits into from
Aug 9, 2020
Merged

Ebook social links #1142

merged 23 commits into from
Aug 9, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Aug 2, 2020

Fixes #1140

Profile picture is now at the side and author links now link the social media profiles:

Author bio with links

For contributors I decided to leave the Twitter handle in where there is one, to allow some way of readers to follow contributors (well at least most of them). Figured GitHub user id is less useful for this and websites will have long URLs so Twitter is best:

Remove social media icons and replace with Twitter username

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Aug 2, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Aug 2, 2020
@tunetheweb tunetheweb added this to TODO in 2020 via automation Aug 2, 2020
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you direct my attention to the lines of code where the Twitter account is added to the contributor's name in the Appendix?

src/static/css/ebook.css Outdated Show resolved Hide resolved
2020 automation moved this from TODO to In progress Aug 9, 2020
@tunetheweb tunetheweb merged commit e32f8fe into main Aug 9, 2020
2020 automation moved this from In progress to Done Aug 9, 2020
@tunetheweb tunetheweb deleted the ebook_social_links branch August 9, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
No open projects
2020
  
Done
Development

Successfully merging this pull request may close these issues.

[Ebook] Author alignment and social links
3 participants