Add support for LinkedIn contributor links #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
reviewed
Aug 3, 2020
There was a problem hiding this comment.
We should give it, its own aria-label (see lines 72-74 of templates/lang/2019/base.html) and also add to authors templates (see templates/base/2019/base_chapter.html and templates/base/2019/ebook.ejs.html) but not ebook contributors assuming #1142 gets merged.
But happy to merge this for now and do those in a separate PR (either you or me) if you want as we have no authors with linkedin profiles yet, if you don’t have time to work on that right now?
|
Actually I’ll do that as part of #1142 as touching a lot of that code and will avoid a merge conflict for me. Let’s merge this! |
tunetheweb
approved these changes
Aug 3, 2020
|
Thanks for this @catalinred! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1136