Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run website tests on every pull request #1210

Merged
merged 6 commits into from
Aug 13, 2020
Merged

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Aug 13, 2020

As discussed on Slack, this enables us to add branch protections to the main branch.

The cost is a few more runs which doesn't have anything to do with website (e.g. on SQL files) but that's a minor cost compared to gains.

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Aug 13, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Aug 13, 2020
@tunetheweb tunetheweb added this to TODO in 2020 via automation Aug 13, 2020
@tunetheweb tunetheweb changed the title Run test on every pull request Run website tests on every pull request Aug 13, 2020
Copy link
Contributor

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

2020 automation moved this from TODO to In progress Aug 13, 2020
@tunetheweb tunetheweb merged commit c110410 into main Aug 13, 2020
2020 automation moved this from In progress to Done Aug 13, 2020
@tunetheweb tunetheweb deleted the run_test_on_every_commit branch August 13, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
No open projects
2020
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants