Translate JavaScript chapter to Portuguese #1310
Conversation
There was a problem hiding this comment.
Looks pretty good. A few things we should change though:
- We moved to new figure markup very recently
- You've bolded a number of sentences but not sure why?
- Translated versions of MDN
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
revised and fixed suggestions Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
revised and fixed suggestions Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
sorry some details went unnoticed. Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
There was a problem hiding this comment.
Almost there now!
Can your add yourself to the src/config/2019.json file? It's in alphabetical order first name so add yourself to line 1059 or thereabouts?
Also note that we can't actually send this language (and this chapter) live until we translate templates/en/2019/featured_chapters.html - could you tackle that one next? Then we can release this.
read my mind.
Okay, I'm in no hurry, but I will still resolve this as soon as possible so that it is released to the community. |
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
forgive me for the delay in the translation.
Makes progress on #505