Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate featured_chapters to Portuguese #1319

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Translate featured_chapters to Portuguese #1319

merged 1 commit into from
Sep 27, 2020

Conversation

HakaCode
Copy link
Contributor

@HakaCode HakaCode commented Sep 27, 2020 •
edited
Loading

Makes progress on #505

@HakaCode HakaCode added the translation world wide web label Sep 27, 2020
tunetheweb
tunetheweb approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

As you translate each's chapter you should check you've translated it consistently and also enable the chapter in line 1 of this file.

@tunetheweb tunetheweb added this to TODO in 2020 via automation Sep 27, 2020
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Sep 27, 2020
@tunetheweb tunetheweb merged commit 7cedb1c into HTTPArchive:main Sep 27, 2020
2020 automation moved this from TODO to Done Sep 27, 2020
@HakaCode
Copy link
Contributor Author

HakaCode commented Sep 27, 2020 •
edited
Loading

LGTM! Thanks.

As you translate each's chapter you should check you've translated it consistently and also enable the chapter in line 1 of this file.

@bazzadp,
I understood, I ended up seeing how the website would look with the new language "Portuguese", and I understood the logic used, thanks for the help with the tips.

@HakaCode HakaCode deleted the pt_featured_chapters branch June 10, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
translation world wide web
Projects
No open projects
2020
  
Done
Milestone
2019 Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HakaCode @tunetheweb