Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remainder of A11Y queries #161

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Remainder of A11Y queries #161

merged 1 commit into from
Sep 16, 2019

Conversation

foxdavidj
Copy link
Contributor

9.25 is a copy of 12.07

I don't think we can reliably implement 9.23. Without a custom metric we're forced to use regex here, and regex cannot reliably test if an element is WITHIN another, like in the example below:

<div role="radiogroup">
  <input type="radio" name="grouped" value="1" checked>
  <input type="radio" name="grouped" value="2">
  <input type="radio" name="grouped" value="3">
</div>

<!--
  Will still match the inputs below with regex like <[^>]+\brole=['"]radiogroup
  And we can't find out where this group ends
-->
<input type="radio" name="not-grouped" value="1" checked>
<input type="radio" name="not-grouped" value="2">

Should we mark this one as non-implementable?

@rviscomi
Copy link
Member

Should we mark this one as non-implementable?

SGTM

@rviscomi
Copy link
Member

Updated the results sheet.

@rviscomi rviscomi merged commit 32238a4 into HTTPArchive:master Sep 16, 2019
@rviscomi rviscomi added the analysis Querying the dataset label Sep 16, 2019
@rviscomi rviscomi added this to the Content written milestone Sep 16, 2019
@foxdavidj foxdavidj deleted the a11y branch October 1, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants