Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create markup.md #184

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Create markup.md #184

merged 5 commits into from
Oct 10, 2019

Conversation

bkardell
Copy link
Contributor

@bkardell bkardell commented Oct 2, 2019

Initial draft, includes (( TODO: ... comments that reference the google doc draft for sample images - I can work with whomever to figure out how we can directly use this data - currently it involves kind of a number of steps and a copy of the generated spreadsheet))

Closes #133

Initial draft, includes (( TODO:  ... comments that reference the google doc draft for sample images - I can work with whomever to figure out how we can directly use this data - currently it involves kind of a number of steps and a copy of the generated spreadsheet))
@rviscomi rviscomi added the writing Related to wording and content label Oct 2, 2019
@rviscomi rviscomi added this to the Content written milestone Oct 2, 2019
@rviscomi rviscomi requested a review from zcorpan October 2, 2019 18:38
@rviscomi
Copy link
Member

rviscomi commented Oct 3, 2019

@zcorpan does this have your blessing? 🙏

Copy link
Contributor

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Many nits about the markdown. One substantive comment for the perspective section.

src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
src/content/en/2019/markup.md Outdated Show resolved Hide resolved
@rviscomi
Copy link
Member

@bkardell assigning this back to you to resolve @zcorpan's feedback

bkardell and others added 3 commits October 10, 2019 09:55
Merge all the beautiful mardown corrections

Co-Authored-By: Simon Pieters <zcorpan@gmail.com>
add the note to todo: insert images rick generated for us..
@bkardell bkardell merged commit 316f760 into master Oct 10, 2019
@rviscomi rviscomi deleted the bkardell-patch-1 branch June 18, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write content: Chapter 3. Markup
3 participants