-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create markup.md #184
Merged
Merged
Create markup.md #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial draft, includes (( TODO: ... comments that reference the google doc draft for sample images - I can work with whomever to figure out how we can directly use this data - currently it involves kind of a number of steps and a copy of the generated spreadsheet))
@zcorpan does this have your blessing? 🙏 |
zcorpan
requested changes
Oct 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Many nits about the markdown. One substantive comment for the perspective section.
Merge all the beautiful mardown corrections Co-Authored-By: Simon Pieters <zcorpan@gmail.com>
zcorpan
approved these changes
Oct 10, 2019
add the note to todo: insert images rick generated for us..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft, includes (( TODO: ... comments that reference the google doc draft for sample images - I can work with whomever to figure out how we can directly use this data - currently it involves kind of a number of steps and a copy of the generated spreadsheet))
Closes #133