Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11Y chapter #234

Merged
merged 4 commits into from
Oct 30, 2019
Merged

A11Y chapter #234

merged 4 commits into from
Oct 30, 2019

Conversation

foxdavidj
Copy link
Contributor

Closes #155

This is an in-progress PR for the A11Y chapter. Currently converting the google doc into markdown.

kleinab
kleinab reviewed Oct 25, 2019
View reviewed changes
Copy link

@kleinab kleinab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments on the conclusion. The biggest change I'd like to propose is creating a new section, Media on the web.

I tried to directly make changes to this PR but since it's off of your branch, I wasn't able to do it. (Perhaps it's my unfamiliarity with github which prevented me.)

src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
@rviscomi rviscomi added the writing Related to wording and content label Oct 25, 2019
@rviscomi rviscomi added this to the Content written milestone Oct 25, 2019
@foxdavidj
Copy link
Contributor Author

@kleinab Thanks for the edits, I'll wait till you're finished in the Google Doc so I can pull them all in at once 👍

@ljme
Copy link

ljme commented Oct 26, 2019

@kleinab Thanks for the edits, I'll wait till you're finished in the Google Doc so I can pull them all in at once 👍

I'm editing today, including adding alt text to each graph. I'll embed the alt text using Docs' Alt Text feature and then call it out in a comment, too, so you can't miss it.

@rviscomi rviscomi added the ASAP This issue is blocking progress label Oct 29, 2019
rviscomi
rviscomi reviewed Oct 29, 2019
View reviewed changes
src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
src/content/en/2019/a11y.md Outdated Show resolved Hide resolved
@foxdavidj
Copy link
Contributor Author

Working on this now. Should have this finished up and ready for editing by tomorrow afternoon.

@foxdavidj
Copy link
Contributor Author

@rviscomi All the reviewers and authors LGTMd on the google doc. Permission to merge? 🥇

@rviscomi
Copy link
Member

image

@foxdavidj foxdavidj merged commit 37b5e5a into HTTPArchive:master Oct 30, 2019
@foxdavidj foxdavidj deleted the a11y-chapter-md branch October 30, 2019 06:09
@rviscomi rviscomi removed the ASAP This issue is blocking progress label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi left review comments

@kleinab kleinab kleinab left review comments

Assignees
No one assigned
Labels
writing Related to wording and content
Projects
None yet
Milestone
Content written
Development

Successfully merging this pull request may close these issues.

Write content: Chapter 9. Accessibility
4 participants
@foxdavidj @ljme @rviscomi @kleinab