-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11Y chapter #234
A11Y chapter #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments on the conclusion. The biggest change I'd like to propose is creating a new section, Media on the web.
I tried to directly make changes to this PR but since it's off of your branch, I wasn't able to do it. (Perhaps it's my unfamiliarity with github which prevented me.)
@kleinab Thanks for the edits, I'll wait till you're finished in the Google Doc so I can pull them all in at once 👍 |
I'm editing today, including adding alt text to each graph. I'll embed the alt text using Docs' Alt Text feature and then call it out in a comment, too, so you can't miss it. |
Working on this now. Should have this finished up and ready for editing by tomorrow afternoon. |
@rviscomi All the reviewers and authors LGTMd on the google doc. Permission to merge? 🥇 |
Closes #155
This is an in-progress PR for the A11Y chapter. Currently converting the google doc into markdown.