-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Commit to Add Spanish Support #386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion of Web Almanac. Adding Spanish language into language.py. Adding a 25x25 Spain's flag to be used when the language selected is spanish.
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 22.5%, saving 103 bytes
Some images were already optimised
|
JMPerez
reviewed
Nov 9, 2019
JMPerez
reviewed
Nov 9, 2019
JMPerez
reviewed
Nov 9, 2019
JMPerez
reviewed
Nov 9, 2019
JMPerez
reviewed
Nov 9, 2019
JMPerez
approved these changes
Nov 9, 2019
@c-torres I have added very minor suggestions in case you want to consider them. Other than that it looks great! |
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
I added the suggestion by @JMPerez, good catches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to receive feedback from @JMPerez and @taytus regarding two Spanish translation questions: