Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First Commit to Add Spanish Support #386

Merged
merged 7 commits into from
Nov 9, 2019
Merged

First Commit to Add Spanish Support #386

merged 7 commits into from
Nov 9, 2019

Conversation

c-torres
Copy link
Contributor

@c-torres c-torres commented Nov 9, 2019

  • Added the base.html and index.html needed to work with the Spanish version.
  • Added Spanish language into language.py.
  • Added a 25x25 Spain's flag to be used when the language selected is Spanish.
  • Changed the CSS for language switcher option elements, because currently the options were displaying in white font over white background.

I would love to receive feedback from @JMPerez and @taytus regarding two Spanish translation questions:

  • Commit goes using Web Alamanac as in English, suggestion made by @rviscomi, are we OK with this?
  • Contributors was translated using Contribuidores which is not gender neutral, I was not able to found a gender neutral word. Should we go with Contribuidoras y contribuidores? Suggestions?

Creating the folders and files structure needed to support spanish ve…
7824502 
…rsion of Web Almanac. Adding Spanish language into language.py. Adding a 25x25 Spain's flag to be used when the language selected is spanish.
@rviscomi rviscomi added the translation world wide web label Nov 9, 2019
@rviscomi rviscomi added this to the Après Ski milestone Nov 9, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2019

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 22.5%, saving 103 bytes

Filename Before After Improvement
src/static/images/es.png 458 bytes 355 bytes -22.5%
Some images were already optimised
  • src/static/images/2019/01_JavaScript/hero_lg.jpg
  • src/static/images/2019/01_JavaScript/hero_sm.jpg
  • src/static/images/2019/01_JavaScript/hero_xl.jpg
  • src/static/images/2019/01_JavaScript/js-processing-reddit.png
  • src/static/images/2019/02_CSS/hero_lg.jpg
  • src/static/images/2019/02_CSS/hero_sm.jpg
  • src/static/images/2019/02_CSS/hero_xl.jpg
  • src/static/images/2019/03_Markup/element_categories.png
  • src/static/images/2019/03_Markup/hero_lg.jpg
  • src/static/images/2019/03_Markup/hero_sm.jpg
  • src/static/images/2019/03_Markup/hero_xl.jpg
  • src/static/images/2019/03_Markup/hixie_element_types_per_page.png
  • src/static/images/2019/03_Markup/hixie_elements_per_page.png
  • src/static/images/2019/04_Media/hero_lg.jpg
  • src/static/images/2019/04_Media/hero_sm.jpg
  • src/static/images/2019/04_Media/hero_xl.jpg
  • src/static/images/2019/05_Third_Parties/hero_lg.jpg
  • src/static/images/2019/05_Third_Parties/hero_sm.jpg
  • src/static/images/2019/05_Third_Parties/hero_xl.jpg
  • src/static/images/2019/06_Fonts/hero_lg.jpg
  • src/static/images/2019/06_Fonts/hero_sm.jpg
  • src/static/images/2019/06_Fonts/hero_xl.jpg
  • src/static/images/2019/07_Performance/fig1.png
  • src/static/images/2019/07_Performance/fig10.png
  • src/static/images/2019/07_Performance/fig11.png
  • src/static/images/2019/07_Performance/fig12.png
  • src/static/images/2019/07_Performance/fig13.png
  • src/static/images/2019/07_Performance/fig14.png
  • src/static/images/2019/07_Performance/fig15.png
  • src/static/images/2019/07_Performance/fig16.png
  • src/static/images/2019/07_Performance/fig17.png
  • src/static/images/2019/07_Performance/fig18.png
  • src/static/images/2019/07_Performance/fig2.png
  • src/static/images/2019/07_Performance/fig3.png
  • src/static/images/2019/07_Performance/fig4.png
  • src/static/images/2019/07_Performance/fig5.png
  • src/static/images/2019/07_Performance/fig6.png
  • src/static/images/2019/07_Performance/fig7.png
  • src/static/images/2019/07_Performance/fig8.png
  • src/static/images/2019/07_Performance/hero_lg.jpg
  • src/static/images/2019/07_Performance/hero_sm.jpg
  • src/static/images/2019/07_Performance/hero_xl.jpg
  • src/static/images/2019/07_Performance/nav-timing.png
  • src/static/images/2019/08_Security/hero_lg.jpg
  • src/static/images/2019/08_Security/hero_sm.jpg
  • src/static/images/2019/08_Security/hero_xl.jpg
  • src/static/images/2019/09_Accessibility/example-of-a-skip-link-on-google.com.png
  • src/static/images/2019/09_Accessibility/example-of-good-and-bad-color-contrast-lookzook.png
  • src/static/images/2019/09_Accessibility/hero_lg.jpg
  • src/static/images/2019/09_Accessibility/hero_sm.jpg
  • src/static/images/2019/09_Accessibility/hero_xl.jpg
  • src/static/images/2019/10_SEO/hero_lg.jpg
  • src/static/images/2019/10_SEO/hero_sm.jpg
  • src/static/images/2019/10_SEO/hero_xl.jpg
  • src/static/images/2019/11_PWA/hero_lg.jpg
  • src/static/images/2019/11_PWA/hero_sm.jpg
  • src/static/images/2019/11_PWA/hero_xl.jpg
  • src/static/images/2019/12_Mobile_Web/america-online-1000-hours-free.jpg
  • src/static/images/2019/12_Mobile_Web/example-of-easy-to-hit-tap-targets-lookzook.png
  • src/static/images/2019/12_Mobile_Web/example-of-good-and-bad-color-contrast-lookzook.png
  • src/static/images/2019/12_Mobile_Web/hero_lg.jpg
  • src/static/images/2019/12_Mobile_Web/hero_sm.jpg
  • src/static/images/2019/12_Mobile_Web/hero_xl.jpg
  • src/static/images/2019/13_Ecommerce/hero_lg.jpg
  • src/static/images/2019/13_Ecommerce/hero_sm.jpg
  • src/static/images/2019/13_Ecommerce/hero_xl.jpg
  • src/static/images/2019/14_CMS/cms-logos.png
  • src/static/images/2019/14_CMS/hero_lg.jpg
  • src/static/images/2019/14_CMS/hero_sm.jpg
  • src/static/images/2019/14_CMS/hero_xl.jpg
  • src/static/images/2019/14_CMS/perf-perception.png
  • src/static/images/2019/14_CMS/web-evolution.png
  • src/static/images/2019/15_Compression/ch15_fig1_compression_algorithms.jpg
  • src/static/images/2019/15_Compression/ch15_fig10_lighthouse_compression_byte_savings.jpg
  • src/static/images/2019/15_Compression/ch15_fig2_compressed_content_types.jpg
  • src/static/images/2019/15_Compression/ch15_fig3_compressed_content_types_filtered.jpg
  • src/static/images/2019/15_Compression/ch15_fig4_compression_by_content_type_desktop.jpg
  • src/static/images/2019/15_Compression/ch15_fig5_compression_by_content_type_mobile.jpg
  • src/static/images/2019/15_Compression/ch15_fig6_compression_by_content_type_pct_desktop.jpg
  • src/static/images/2019/15_Compression/ch15_fig7_compression_by_content_type_pct_mobile.jpg
  • src/static/images/2019/15_Compression/ch15_fig8_lighthouse.jpg
  • src/static/images/2019/15_Compression/ch15_fig9_lighthouse_compression_scores.jpg
  • src/static/images/2019/15_Compression/hero_lg.jpg
  • src/static/images/2019/15_Compression/hero_sm.jpg
  • src/static/images/2019/15_Compression/hero_xl.jpg
  • src/static/images/2019/16_Caching/ch16_fig1_redbot_example.jpg
  • src/static/images/2019/16_Caching/ch16_fig10_invalid_date_formats.jpg
  • src/static/images/2019/16_Caching/ch16_fig11_vary_header.jpg
  • src/static/images/2019/16_Caching/ch16_fig12_header_example_with_cookie.jpg
  • src/static/images/2019/16_Caching/ch16_fig13_cookies_on_cacheable_responses.jpg
  • src/static/images/2019/16_Caching/ch16_fig14_service_worker_adoption.jpg
  • src/static/images/2019/16_Caching/ch16_fig15_lighthouse_example.jpg
  • src/static/images/2019/16_Caching/ch16_fig16_lighthouse_cache_score.jpg
  • src/static/images/2019/16_Caching/ch16_fig17_lighthouse_cache_byte_savings.jpg
  • src/static/images/2019/16_Caching/ch16_fig2_cache_control_expires.jpg
  • src/static/images/2019/16_Caching/ch16_fig3_distribution_of_cacheable_responses.jpg
  • src/static/images/2019/16_Caching/ch16_fig4_caheability_by_content_type_desktop.jpg
  • src/static/images/2019/16_Caching/ch16_fig5_caheability_by_content_type_mobile.jpg
  • src/static/images/2019/16_Caching/ch16_fig6_usage_of_cache_control_expires.jpg
  • src/static/images/2019/16_Caching/ch16_fig7_cache_control_directives.jpg
  • src/static/images/2019/16_Caching/ch16_fig8_resource_age.jpg
  • src/static/images/2019/16_Caching/ch16_fig9_validating_freshness.jpg
  • src/static/images/2019/16_Caching/hero_lg.jpg
  • src/static/images/2019/16_Caching/hero_sm.jpg
  • src/static/images/2019/16_Caching/hero_xl.jpg
  • src/static/images/2019/17_CDN/hero_lg.jpg
  • src/static/images/2019/17_CDN/hero_sm.jpg
  • src/static/images/2019/17_CDN/hero_xl.jpg
  • src/static/images/2019/18_Page_Weight/ch18_fig1_conversion_difference.png
  • src/static/images/2019/18_Page_Weight/ch18_fig2_conversion_graph.png
  • src/static/images/2019/18_Page_Weight/ch18_fig3_gif_cdf.png
  • src/static/images/2019/18_Page_Weight/hero_lg.jpg
  • src/static/images/2019/18_Page_Weight/hero_sm.jpg
  • src/static/images/2019/18_Page_Weight/hero_xl.jpg
  • src/static/images/2019/19_Resource_Hints/hero_lg.jpg
  • src/static/images/2019/19_Resource_Hints/hero_sm.jpg
  • src/static/images/2019/19_Resource_Hints/hero_xl.jpg
  • src/static/images/2019/20_HTTP_2/hero_lg.jpg
  • src/static/images/2019/20_HTTP_2/hero_sm.jpg
  • src/static/images/2019/20_HTTP_2/hero_xl.jpg
  • src/static/images/2019/20_HTTP_2/http2usage.png
  • src/static/images/2019/20_HTTP_2/numresources.png
  • src/static/images/2019/20_HTTP_2/TCPconnections.png
  • src/static/images/2019/20_HTTP_2/whatpushisusedfor.png
  • src/static/images/avatars/0.jpg
  • src/static/images/avatars/1.jpg
  • src/static/images/avatars/10.jpg
  • src/static/images/avatars/11.jpg
  • src/static/images/avatars/12.jpg
  • src/static/images/avatars/13.jpg
  • src/static/images/avatars/14.jpg
  • src/static/images/avatars/2.jpg
  • src/static/images/avatars/3.jpg
  • src/static/images/avatars/4.jpg
  • src/static/images/avatars/5.jpg
  • src/static/images/avatars/6.jpg
  • src/static/images/avatars/7.jpg
  • src/static/images/avatars/8.jpg
  • src/static/images/avatars/9.jpg
  • src/static/images/blog.png
  • src/static/images/character-file.png
  • src/static/images/character-hat.png
  • src/static/images/character-markup.png
  • src/static/images/character-measure.png
  • src/static/images/character-painter.png
  • src/static/images/character-star.png
  • src/static/images/close.png
  • src/static/images/discuss.png
  • src/static/images/dropdown-arrow.png
  • src/static/images/English.png
  • src/static/images/github.png
  • src/static/images/ha-home.png
  • src/static/images/ha.png
  • src/static/images/home-hero-2019-bg.png
  • src/static/images/home-hero-2019.png
  • src/static/images/home-hero-bg.png
  • src/static/images/home-hero.png
  • src/static/images/intro-background-fit.png
  • src/static/images/intro-background.png
  • src/static/images/logo.png
  • src/static/images/logo@2x.png
  • src/static/images/menu.png
  • src/static/images/methodology-banner.png
  • src/static/images/methodology-characters-bg.png
  • src/static/images/methodology-characters.png
  • src/static/images/rectangles.png
  • src/static/images/twitter.png

@JMPerez
Copy link
Contributor

JMPerez commented Nov 9, 2019

@c-torres I have added very minor suggestions in case you want to consider them. Other than that it looks great!

c-torres and others added 5 commits November 9, 2019 10:58
@c-torres @JMPerez
Update src/templates/es/2019/base.html
ba631ec 
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
@c-torres @JMPerez
Update src/templates/es/2019/base.html
ac69985 
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
@c-torres @JMPerez
Update src/templates/es/2019/base.html
91e76f5 
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
@c-torres @JMPerez
Update src/templates/es/2019/index.html
cd89ad6 
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
@c-torres @JMPerez
Update src/templates/es/2019/index.html
959024b 
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
@c-torres
Copy link
Contributor Author

c-torres commented Nov 9, 2019

I added the suggestion by @JMPerez, good catches!

@rviscomi rviscomi merged commit 765f17a into master Nov 9, 2019
@rviscomi rviscomi deleted the c-torres/spanish-translation branch November 9, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMPerez JMPerez JMPerez approved these changes

@taytus taytus Awaiting requested review from taytus

@rviscomi rviscomi Awaiting requested review from rviscomi

Assignees
No one assigned
Labels
translation world wide web
Projects
None yet
Milestone
2019 Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c-torres @JMPerez @rviscomi