Hide rel="alternative" xreflang if only one language exists #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
requested changes
Nov 12, 2019
src/language.py
Outdated
| @@ -18,22 +18,25 @@ def __repr__(self): | |||
|
|
|||
| @property | |||
| def lang_attribute(self): | |||
| # Returns the language attribute (eg "en-US") to be used in HTML. | |||
| return '%s-%s' % (self._lang_code, self._region_code) | |||
| # Returns the language attribute (eg "en" or "en-US") to be used in HTML. | |||
There was a problem hiding this comment.
Let's keep the region in the Language instantiation but since we only want to remove it from the lang attribute we can simplify this method to only return the lang_code:
return self._lang_codeThere was a problem hiding this comment.
To be clear you mean on the last line, like this?:
def lang_attribute(self):
# Returns the language attribute (eg "en" or "en-US") to be used in HTML.
if (self._region_code):
return '%s-%s' % (self._lang_code, self._region_code)
return self._lang_codeI do wonder if we should just rip out any references to region completely from this file?
If you want a new region, could just set up a new language called 'en-US' for example, cause the current chapter folder structure doesn't support regions so, it would basically need to be set up as a language anyway to work.
So why bother having regions at all?
WDYT?
There was a problem hiding this comment.
Sent you #482 with my suggestions. If it LGTY we can merge it into this PR.
There was a problem hiding this comment.
OK accepted that and then updated the comments to explain why we have two functions the same.
Also did a slight change:
return '%s' % (self._lang_code)to
return self._lang_codeMerge away if happy!
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 38.3%, saving 42.75 KB
Some images were already optimised
|
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 38.3%, saving 42.75 KB
Some images were already optimised
|
rviscomi
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #286 (comment)