Translation of Caching chapter to French #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: update # The commit message #2 will be skipped: # review # The commit message #3 will be skipped: # review #2 # The commit message #4 will be skipped: # advance # The commit message #5 will be skipped: # update # The commit message #6 will be skipped: # update translation # The commit message #7 will be skipped: # update # The commit message #8 will be skipped: # update # # update # The commit message #9 will be skipped: # update
(typofixes, translating alternatives)
To facilitate the review of original text vs. translation side-by-side. Also: microtypo fixes.
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
If it's not too much effort, could you also fix this in the English version as part of this PR as looks wrong there: 6% of requests have a time to time (TTL) should be: 6% of requests have a Time to Live (TTL) Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
Do we need to state that all the directives are English language terms or is that overkill? If so need to check this doesn't mess up the markdown->HTML script. Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
tunetheweb
requested changes
Mar 6, 2020
There was a problem hiding this comment.
Couple of comments for you there @allemas . Thanks for you patience with this and almost ready to merge! 😊
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>
|
I didn't find the last change requested :( |
|
Yeah was all hidden away in the review: #669 (comment) LGTM so let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request with reviews and page generation :)
Makes progress on #539