Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI workflow and linting issues #215

Closed
wants to merge 4 commits into from
Closed

fix CI workflow and linting issues #215

wants to merge 4 commits into from

Conversation

hbruch
Copy link

@hbruch hbruch commented May 22, 2023

As discussed in #214, the actions workflow currently fails.

The error message seems related to actions/setup-python#560 or actions/setup-python#572, though tests.yaml uses ubuntu-latest and no caching.

This PR

  • uses ubuntu:22.04 as container, instead of python:3. This should be sufficient, as python should be installed via the setup-python action.
  • bumps some github actions versions to their current version.
  • fixes some minor formatting issues highlighted by black

@hbruch hbruch marked this pull request as draft May 22, 2023 16:17
@hbruch hbruch marked this pull request as ready for review May 22, 2023 16:19
@hbruch
Copy link
Author

hbruch commented May 22, 2023

As running the workflow requires approval, @HTenkanen could you please approve the workflow (not the PR/merge).

@hbruch hbruch changed the title WIP: fix ci workflow issue fix CI workflow and linting issues May 24, 2023
@hbruch hbruch mentioned this pull request May 24, 2023
@nickodell
Copy link

@hbruch Do you happen to know why CI is failing here? It's sufficiently old that GH deleted the CI logs. Would be happy to lend a hand.

HTenkanen added a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants