Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seasonal Shop Closed State Style Change #9457

Open
lemoness opened this issue Nov 10, 2017 · 16 comments
Open

Seasonal Shop Closed State Style Change #9457

lemoness opened this issue Nov 10, 2017 · 16 comments

Comments

@lemoness
Copy link
Contributor

lemoness commented Nov 10, 2017

There current Seasonal Shop style is incorrect.

This section should be removed:

screen shot 2017-11-09 at 7 03 10 pm

The text should actually say, "The Seasonal Shop is open during Habitica's four Grand Galas."

Grand Galas should link to the Wiki page: https://habitica.fandom.com/wiki/Grand_Galas

Note that @Tressley will invite whoever decides to claim this ticket to our Zeplin so that they can have access to details about spacing and all the necessary files, so they'll need to specify which email he should invite!

@hextal
Copy link

hextal commented Nov 10, 2017

Can I give it a shot? looks like a pretty good first issue wouldn't mind giving it a shot if someone can guide me a little hassantalpur@gmail.com

@paglias
Copy link
Contributor

paglias commented Nov 10, 2017

@hextal sure! You can open a PR and ping me if you have any question

@Tressley
Copy link
Collaborator

Tressley commented Nov 11, 2017

@hextal -- It looks like you were invited to Zeplin before I had a chance to get the artboard imported! You can now review the design here: https://zpl.io/VKGWjv6

@hextal
Copy link

hextal commented Nov 12, 2017

hey guys im pretty lost here, im trying to figure out where to edit the js/css?
and where can i find the sprites especially for the shop_open and the background?
currently im only seeing the halloween one and i dont see where to extract the new one on zeplin although im still kinda getting used to zeplin

@paglias
Copy link
Contributor

paglias commented Nov 12, 2017

@hextal the css/js files are inside website/client/components: the files ending in .vue have css/js/html inside, the shop closed image can be downloaded from zeplin, click on it and on the right there should be a link to download it in svg format

@librarianmage
Copy link
Contributor

Should this be marked as in progress?

@lemoness
Copy link
Contributor Author

I've updated the labels on this ticket!

@librarianmage
Copy link
Contributor

Hello @hextal! How are you doing on this?

@lemoness
Copy link
Contributor Author

I'm updating the labels on this ticket to reflect that it's ready to claim!

@veeeeeee veeeeeee changed the title Seasonal Shop Closed State Style Bugs Seasonal Shop Closed State Style Change Jul 7, 2020
@thewilloftheshadow
Copy link
Contributor

Is this issue still needed? If so, I can do it
thebotoftheshadow@gmail.com

@Tressley
Copy link
Collaborator

Tressley commented Nov 9, 2020

@thewilloftheshadow -- I've invited you to our Zeplin project and marked this issue as in progress for you. You can view the Zeplin artboard here: https://zpl.io/V1PQw5m

@thewilloftheshadow
Copy link
Contributor

@Tressley which one of these are we using?

This one is from Zeplin:
image

This one is currently on the website:
image

@Tressley
Copy link
Collaborator

@thewilloftheshadow -- You'll use the one currently on the website, the closed image state.

@thewilloftheshadow
Copy link
Contributor

I think I’m going to have to let this one go for someone else. Turns out I am really really bad at front end work, and I’m going to stick to the API and server-side of things 😂😂

@gengisdave
Copy link

Hi, I wanted to start helping out and I set up a local instance, then I've started looking for beginner tasks.

image

The link is working and it opens in the same page (I've found no reference to opening in a new tab), but I'm not sure if it solves the issue (it's just a string replace in the translation file) or some graphic on the page should be changed.

Thanks

@CuriousMagpie
Copy link
Member

@Tressley Can you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests