-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seasonal Shop Closed State Style Change #9457
Comments
Can I give it a shot? looks like a pretty good first issue wouldn't mind giving it a shot if someone can guide me a little hassantalpur@gmail.com |
@hextal sure! You can open a PR and ping me if you have any question |
@hextal -- It looks like you were invited to Zeplin before I had a chance to get the artboard imported! You can now review the design here: https://zpl.io/VKGWjv6 |
hey guys im pretty lost here, im trying to figure out where to edit the js/css? |
@hextal the css/js files are inside website/client/components: the files ending in .vue have css/js/html inside, the shop closed image can be downloaded from zeplin, click on it and on the right there should be a link to download it in svg format |
Should this be marked as in progress? |
I've updated the labels on this ticket! |
Hello @hextal! How are you doing on this? |
I'm updating the labels on this ticket to reflect that it's ready to claim! |
Is this issue still needed? If so, I can do it |
@thewilloftheshadow -- I've invited you to our Zeplin project and marked this issue as in progress for you. You can view the Zeplin artboard here: https://zpl.io/V1PQw5m |
@Tressley which one of these are we using? |
@thewilloftheshadow -- You'll use the one currently on the website, the closed image state. |
I think I’m going to have to let this one go for someone else. Turns out I am really really bad at front end work, and I’m going to stick to the API and server-side of things 😂😂 |
Hi, I wanted to start helping out and I set up a local instance, then I've started looking for beginner tasks. The link is working and it opens in the same page (I've found no reference to opening in a new tab), but I'm not sure if it solves the issue (it's just a string replace in the translation file) or some graphic on the page should be changed. Thanks |
@Tressley Can you take a look at this? |
There current Seasonal Shop style is incorrect.
This section should be removed:
The text should actually say, "The Seasonal Shop is open during Habitica's four Grand Galas."
Grand Galas should link to the Wiki page: https://habitica.fandom.com/wiki/Grand_Galas
Note that @Tressley will invite whoever decides to claim this ticket to our Zeplin so that they can have access to details about spacing and all the necessary files, so they'll need to specify which email he should invite!
The text was updated successfully, but these errors were encountered: