Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added team photos, gimme dat sweet hktbrfst PR #73

Merged
merged 5 commits into from
Oct 11, 2018
Merged

Added team photos, gimme dat sweet hktbrfst PR #73

merged 5 commits into from
Oct 11, 2018

Conversation

mjkaufer
Copy link
Contributor

@mjkaufer mjkaufer commented Oct 2, 2018

Notice me @jacobj10

Example of output
here

@mjkaufer mjkaufer mentioned this pull request Oct 11, 2018
Closed
3 tasks
jacobj10
jacobj10 approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@jacobj10 jacobj10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM B0$s, in the future we can try and populate pictures programmatically via plugins but one can dream.

@mjkaufer
Copy link
Contributor Author

@ehsanmasdar can I merge this, it says build fails but I don't believe it

@ehsanmasdar ehsanmasdar self-requested a review October 11, 2018 21:21
ehsanmasdar
ehsanmasdar requested changes Oct 11, 2018
View reviewed changes
Copy link
Member

@ehsanmasdar ehsanmasdar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehsan needs a good picture

@hackgbot
Copy link
Contributor

Hey y'all! A deployment of this PR can be found here:
https://hackgt-org-website-team-photos.pr.hack.gt

@mjkaufer mjkaufer merged commit 8c69a25 into master Oct 11, 2018
@ayush-goyal ayush-goyal deleted the team-photos branch July 22, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsanmasdar ehsanmasdar ehsanmasdar approved these changes

@jacobj10 jacobj10 jacobj10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjkaufer @hackgbot @ehsanmasdar @jacobj10