chore: upgrade yarn to v4 and other dependencies #5014
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@abnud11 you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 114
- 72
58% JSON
26% GitHubActions
8% GitHubActions (tests)
5% TSX (tests)
4% OtherGenerated lines of change
+ 37,863
- 26,487
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
There was a problem hiding this comment.
The yarn and dependency updates look good from my perspective and seem like they should work as long as the build completes successfully and tests are passing. No concerns here. Thanks!
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 95
- 67
66% JSON
30% GitHubActions
2% Other
2% JSON with Comments
1% YAMLGenerated lines of change
+ 37,683
- 26,447
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 95
- 67
66% JSON
30% GitHubActions
2% Other
2% JSON with Comments
1% YAMLGenerated lines of change
+ 37,683
- 26,447
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
abnud11
force-pushed
the
chore/upgrade-dependencies
branch
from
de5f209
to
d66c29d
Compare
…into chore/upgrade-dependencies
|
After upgrading For some reason, In short, you need to focus on the element to dispatch keydown, then dispatch keydown on |
src/test/datepicker_test.test.tsx
Outdated
| @@ -1251,7 +1251,8 @@ describe("DatePicker", () => { | |||
| expect(formatDate(data.instance.state.preSelection!, data.testFormat)).toBe( | |||
| formatDate(data.copyM, data.testFormat), | |||
| ); | |||
| fireEvent.keyDown(selectedDayNode!, getKey(KeyType.ArrowRight)); | |||
| (selectedDayNode as HTMLElement).focus(); | |||
| fireEvent.keyDown(document.activeElement || document.body, getKey(KeyType.ArrowRight)); | |||
There was a problem hiding this comment.
Change from last time is library bumps only. Nothing more to add.
Reviewed with ❤️ by PullRequest
|
Can we approve the workflows and merge this PR please ? |
There was a problem hiding this comment.
Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.
|
Fix merge conflicts and prettier error The workflows should succeed now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5014 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 29 29
Lines 3343 3343
Branches 1390 1404 +14
=======================================
Hits 3238 3238
+ Misses 105 103 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
| "@types/react": "^18.3.4", | ||
| "@types/react-dom": "^18.3.0", |
There was a problem hiding this comment.
yarn type-check which is part of Github test workflow fails without these 2 packages, honestly don't know why it didn't error before.
.husky/pre-commit
Outdated
There was a problem hiding this comment.
This is part of husky 9 upgrade, while husky was on version 9 before this PR, this change should have been done when migrating from 8 to 9, see this:
https://github.com/typicode/husky/releases/tag/v9.0.1
In particular, read How To Migrate
@martijnrusschen
|
Ok thanks let's resolve the last conflict and merge this. |
…into chore/upgrade-dependencies
|
@martijnrusschen conflicts fixed. |
|
Something is wrong with Eslint. I can't get it to work anymore. It seems to consistently fail now, and as you can see in this PR, the linter didn't run but did succeed. |
|
Same seems to happen with sass-lint |
|
@martijnrusschen it works on my machine correctly, what exactly doesn't work on your machine? did you run |
|
also, the linter ran as part of |
|
And |
|
@martijnrusschen that job fails at |
|
but if you compare it to an older run, let's say this one: https://github.com/Hacker0x01/react-datepicker/actions/runs/10460719357/job/28967495012. you will see more output for the lint job. It should run 2 linters, and it doesn't seem to run normally. |
|
That's because it was using yarn v1, with yarn v4 it doesn't show what commands it runs, only their output if there is any output, I confirmed on my local machine that |
name: Upgrade dependencies of root project
about: it's about upgrading deps of the project
title: "Upgrade dependencies of root project"
labels: ""
assignees: "abnud1"
Description
Problem
This PR upgrades yarn from v1 to v4 using corepack, it also upgrades other deps to the latest version, especially major updates like
react-testing-library, Typescript from 5.4 to 5.5, and others.This PR also upgrades CodeQL Github action to use v3.
Changes
I updated
package.jsonalong withyarn.lock,codeql-analysis.ymlfile, I also added@types/reactand@types/react-domand enabledskipLibCheck: truein tsconfig in order to makeyarn type-checkscript successfulContribution checklist