Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Task Removal and no repeating tasks #54

Closed
wants to merge 3 commits into from

Conversation

philippmao
Copy link
Contributor

This pull request removes the scheduled tasks on a interrupt. Also the xml for the scheduled task is updated such that even if the task is not removed, it is only run once.

@Hackndo
Copy link
Collaborator

Hackndo commented Mar 11, 2021

Hey there,
Thank you very much for your contribution!
Is branch v3.0.0 doing the same? https://github.com/Hackndo/lsassy/blob/3.0.0/lsassy/exec/task.py
I think I already changed the scheduling to a one-shot execution, but if something's missing, could you add your PR on this branch instead of master, as 3.0.0 is going to replace master someday?
Thanks a lot!

@Hackndo Hackndo added the enhancement New feature or request label Mar 11, 2021
@philippmao
Copy link
Contributor Author

ok I have created the pull request on 3.0.0 !

@philippmao philippmao closed this Mar 11, 2021
@Hackndo Hackndo mentioned this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants