Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transchoice twig filter incorrectly determines domain #662

Closed
artursvonda opened this issue Dec 31, 2015 · 4 comments
Closed

transchoice twig filter incorrectly determines domain #662

artursvonda opened this issue Dec 31, 2015 · 4 comments
Labels
fixed

Comments

@artursvonda
Copy link

Looks like transchoice filter thinks the domain is always messages.
Haehnchen added a commit that referenced this issue Jan 1, 2016
@Haehnchen
add array syntax whitelist for twig "trans" domain extraction #662
8af36aa
@Haehnchen
Copy link
Owner

@artursvonda basically its working, can you provide an example of your usage?

@artursvonda
Copy link
Author 

{{ 'key' | transchoice(count, {'%var%': value}, 'domain') }} <- warning about missing translation
{{ 'key' | trans({'%var%': value}, 'domain') }} <- Fine

Haehnchen added a commit that referenced this issue Jan 1, 2016
@Haehnchen
fix regular expression for transchoice count parameter as this can be…
e3c2397 
… a variable #662
@Haehnchen
Copy link
Owner

fixed. idea for better regex are welcome :)

@artursvonda
Copy link
Author

Thanks! :)

@Haehnchen Haehnchen added the fixed label Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artursvonda @Haehnchen