Refactor to use strongly typed data structures #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases the stability of the application but also makes it much easier to read. So many unwraps and type casts removed.
src/api_types.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize)] | ||
| #[allow(non_snake_case)] |
There was a problem hiding this comment.
You can use snake_case variable names while reciving camelCase if instead of #[allow(non_snake_case)] you use #[serde(rename_all = "camelCase")]. I got this info from the serde book if you interested.
There was a problem hiding this comment.
Thank you so much! That's exactly what I want to do but couldn't figure out how.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the stability of the application but also makes it
much easier to read.
So many unwraps and type casts removed.
Will need to test in action for a few nights to make sure there were no extra mistakes.