Update SqlServerObjectsInstaller.cs #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support Azure Sql Managed instance
Codecov Report
@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 68.47% 68.47%
=======================================
Files 156 156
Lines 5136 5136
Branches 1083 1083
=======================================
Hits 3517 3517
Misses 1469 1469
Partials 150 150
Continue to review full report at Codecov.
|
|
@TimSQL, may be we should remove that method completely? |
|
Ok, do i make another commit for that?@odinserj |
|
@TimSQL I've accepted this PR, because it solves the issue anyway. If you wish to remove that method completely, I will be happy to accept the new PR as well. Thanks! |
TimSQL
added a commit
to TimSQL/Hangfire
that referenced
this pull request
Jul 17, 2018
In addition HangfireIO#1222: Removed the function IsSqlEditionSupported to support future versions of SQL Server.
odinserj
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Update SqlServerObjectsInstaller.cs In addition #1222: Removed the function IsSqlEditionSupported to support future versions of SQL Server. * Remove the unused SqlEngineEdition class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Azure Sql Managed instance