Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SqlServerObjectsInstaller.cs #1230

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Conversation

TimSQL
Copy link
Contributor

@TimSQL TimSQL commented Jul 17, 2018

In addition #1222: Removed the function IsSqlEditionSupported to support future versions of SQL Server.

In addition HangfireIO#1222: Removed the function IsSqlEditionSupported to support future versions of SQL Server.
@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #1230 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
+ Coverage   68.47%   68.51%   +0.03%     
==========================================
  Files         156      156              
  Lines        5136     5132       -4     
  Branches     1083     1081       -2     
==========================================
- Hits         3517     3516       -1     
+ Misses       1469     1468       -1     
+ Partials      150      148       -2
Impacted Files Coverage Δ
...rc/Hangfire.SqlServer/SqlServerObjectsInstaller.cs 62.06% <ø> (+4.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768fedb...1fcf874. Read the comment docs.

@odinserj
Copy link
Member

Thanks @TimSQL! Deleting lines is the most awesome stuff in programming 😃

@odinserj odinserj merged commit 7219932 into HangfireIO:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants