feat(timers): Redesign timers and remove dependency on day.js #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the responsibility of time formatting into the timer modules, allowing the removal of the dependency on day.js. This is great for multiple reasons:
vue-i18n
's locale.Also, all three timers received an updated design. Without the use of tabular numbers (and the Source Sans Pro font), the traditional and percentage timers can still display equal-width numbers. This makes the design look more consistent and further reduces the bandwidth required by the app.
Closes #163
Closes #170