Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timers): Redesign timers and remove dependency on day.js #186

Merged
merged 13 commits into from
Feb 19, 2022

Conversation

Hanziness
Copy link
Owner

@Hanziness Hanziness commented Feb 19, 2022

This PR moves the responsibility of time formatting into the timer modules, allowing the removal of the dependency on day.js. This is great for multiple reasons:

  1. Timer formatting is implemented locally in the timer display modules (they can be tweaked, unlike with day.js)
  2. The approximate timer can be translated along with the other strings
  3. There's no need to sync the day.js language option with vue-i18n's locale.
  4. Bundle sizes and the number of dependencies are lower

Also, all three timers received an updated design. Without the use of tabular numbers (and the Source Sans Pro font), the traditional and percentage timers can still display equal-width numbers. This makes the design look more consistent and further reduces the bandwidth required by the app.

Closes #163
Closes #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS font-family and font-size Make time formatting the timers's responsibility
1 participant