Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support? #70

Closed
dhavale opened this issue Dec 3, 2014 · 4 comments
Closed

Unicode support? #70

dhavale opened this issue Dec 3, 2014 · 4 comments

Comments

@dhavale
Copy link

dhavale commented Dec 3, 2014

This is not an issue, its more of a quick question. I looked at user guide and also all issues' logs, I did not find any mention for unicode support. Is logging message in Unicode supported(non-ASCII)?

Any help on this is much appreciated!

@HardySimpson
Copy link
Owner

I did not consider about unicode in C. zlog takes everythin from the interface as bytes...

@dhavale
Copy link
Author

dhavale commented Dec 4, 2014

If zlog takes everything from interface as bytes, means passing a unicode message will be logged correctly right? I tried this on my machine with non-ASCII characters and it worked! Do you see any pitfalls where it may not work? If zlog doesn't care what is inside buffers and logs as it is, I think my case is solved!

@HardySimpson
Copy link
Owner

I have seen the solution of unicode in C, wchar... which is quite complicated. So I give up this solution.

Until now I never met any pitfalls, as in my environment I output log file in Chinese, with the encoding of GBK and UTF-8. They all work well.

@dhavale
Copy link
Author

dhavale commented Dec 31, 2014

Closing the issue as my query was answered. If I hit problem with Unicode characters, I will revisit with details. Thanks for your response!

@dhavale dhavale closed this as completed Dec 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants