Localization

[HarpyWar]

I'm wondering to localize hardcoded text messages in PvPGN. But different game clients have a different encoding.

• Warcraft 3 client uses UTF8, and there is no problem with other languages.
• I know that Starcraft uses conversion CP1252 -> UTF8 to display Russian text (I suppose, it covers Warcraft 2 and Diablo 1). I need an information about Korean, Polish and others.
• Whats encoding for Diablo 2?
• Can WWOL clients display different language text or not? (Tiberian Sun, RA2, etc).

UPDATE
Diablo 2 - UTF8
Starcraft (except Russian) - UTF8
WWOL - IRC encoding, it should not be localized

[RElesgoe]

For StarCraft, as long as you enter the text in whatever language you want it to be, anyone with a computer that is set to that language will be able to read it properly.

[HarpyWar]

Yes, it applies on text messages between users.
But static text in PvPGN code (or in files like motd or helpfile) is saved with an encoding (ASCII, UTF8, etc...). This text must be converted to a user friendly encoding before send, otherwise user will receive "??????" or hieroglyphs instead of a normal text.

[HarpyWar]

How to check Russian encoding in Starcraft, Diablo 1, Warcraft 2.

1. Create a new file in notepad++
2. Make sure the file encoding is ANSI or Windows-1251 (it is russian cyrillic encoding)
3. Write text привет
4. Change the file encoding to Windows-1252. It will display ïðèâåò.
5. Paste that string in your motd.txt. Make sure the file has UTF-8 encoding.
6. Join to the server or send command /motd

The same conversion can be made in code. It is needed to write two functions cp1251_to_cp1252 and cp1252_to_utf8.

[RElesgoe]

I prefer to do convert it by using code to keep the original text, could you write those functions? I could get translators

[HarpyWar]

Sure, it is preferred to convert text by using code. I will write it when I start work on this part of PvPGN.

Do you know people who can do translation of the texts? We need these languages:

        case GAMELANG_ENGLISH_UINT: /* enUS */
        case GAMELANG_GERMAN_UINT:  /* deDE */
        case GAMELANG_CZECH_UINT:   /* csCZ */
        case GAMELANG_SPANISH_UINT: /* esES */
        case GAMELANG_FRENCH_UINT:  /* frFR */
        case GAMELANG_ITALIAN_UINT: /* itIT */
        case GAMELANG_JAPANESE_UINT:    /* jaJA */
        case GAMELANG_KOREAN_UINT:  /* koKR */
        case GAMELANG_POLISH_UINT:  /* plPL */
        case GAMELANG_RUSSIAN_UINT: /* ruRU */
        case GAMELANG_CHINESE_S_UINT:   /* zhCN */
        case GAMELANG_CHINESE_T_UINT:   /* zhTW */

[RElesgoe]

I can get English, German, Spanish, French, Italian, (maybe Korean, not reliable), Polish, Russian translations out of all of those languages from that list. Czech translators shouldn't be difficult to find(I think). I wonder why we support languages like Czech and Japanese, I don't think that their player population on PvPGN servers are big enough to warrant translations

[HarpyWar]

Very well. I'll let you know when the files for translation will be ready.

[RElesgoe]

I found a Japanese translator

[RElesgoe]

I have a Czech translator now

[RElesgoe]

We should only support languages that the games support. So PvPGN's supported languages should become German, English, French, Italian, Korean, Polish, Russian, and Chinese. It should be understandable to include a few other languages such as Spanish

[HarpyWar]

I think all the languages, for which MOTD translated, have their games.

I see Spanish, Czech and Japanese in Warcraft 3 patch list http://ftp.blizzard.com/pub/war3x/patches/pc/

And there is Portuguese for Starcraft

[RElesgoe]

Odd, I didn't see them when I looked at the language list

[Danteoriginal]

error in compilation

You could solve the error please

Thanks for contributing your wonderful work
Regards

[HarpyWar]

@Danteoriginal, It looks like your Visual Studio detects languages array as a function definition without argument list http://msdn.microsoft.com/en-us/library/4k954cff.aspx
I don't know why you receive this error, but now you can ignore two yesterday commits. Actually, it doesn't add a new functionality, because not completed yet.

BTW, are you Dante from the above screenshot? If yes, what is the language of your Starcraft? I assume it is Spanish, but why motd is Portuguese?

[HarpyWar]

@xboi209, localization is still incomplete, but files are prepared for a translation. I just add notes about it https://github.com/HarpyWar/pvpgn/wiki/Localization-Tutorial

Will your translaters localize it directly on github or through your commits?

[RElesgoe]

Some of my translators will use Github, others will just copy and paste it to me.
Are the LUA functions required for the localization?

[HarpyWar]

Ok. We need only translations from the directory https://github.com/HarpyWar/pvpgn/tree/master/conf/i18n (including strings from Lua that are in common.xml)
No needed translate it in code. But if you found an error in english, you have to fix this string in code and in all common.xml files.

[RElesgoe]

Can you write in comments next to the original text about the full usage of it? My translators need context and one or two word phrases are too short to understand its usage.

[HarpyWar]

common.xml generates automatically with a program https://github.com/HarpyWar/pvpgn/tree/master/scripts/localize. Otherwise it will be too hard do not forgot add all strings and next changes synchronization, because of a lot of strings.

There are file and function saved for each string. If the usage is not clear translator should open source file and look in the function.

[RElesgoe]

#37

[RElesgoe]

There needs to be 2 separate files for Chinese Simplified and Chinese Traditional

[HarpyWar]

Yes, there are already 2 separate files for these.

[RElesgoe]

oops, I didn't see that earlier

[RElesgoe]

jpJA should be copied

[Danteoriginal]

yes iam ,harpywar
iam view bug in /con all colapse server,server shutdown

I solved well http://pastebin.com/zu8kvajx

regards,wonderful working

[HarpyWar]

@Danteoriginal, so why Starcraft is Spanish but MOTD is Portuguese on your screenshot?

Please create a pull request for this code and describe what does it fix.

[RElesgoe]

I think PvPGN is displaying Portuguese because that's the language his OS is set to. I believe that a certain packet sends that piece of info to PvPGN.
https://bnetdocs.org/?op=packet&pid=279

[Danteoriginal]

harpywar my starcraft is spanish, Error text in the last paragraph in the mod
the other mod text is correct

then describe what is what solved.
Danteoriginal/pvpgn@5cfd759

sorry for my bad english

[HarpyWar]

@xboi209 Yes, game client sends a country from OS. But motd shows by the game language. It works fine for Warcraft 3, but most Starcraft players use English client.
I will create an option in config localize_by_country = true to get language by a country instead of a game. And a new command /language enUS (alias /lang) to allow user force set his language (for example USA people in Russia, or Russian people use English client).

@Danteoriginal Thanks, I fixed the error. Please create a new issue for each bug that you found.

[HarpyWar]

@xboi209 I removed files that are not translated yet. I see a button Create a new file in Github interface, so translators can create a new files according to original filenames.
news.txt should not be translated.

[RElesgoe]

Why can the contents of bnmotd.txt be sent to the user without any conversion? Do we really need those conversion functions?

[HarpyWar]

I think it relates only to a russian text due to its non standard encoding.

[RElesgoe]

Why isn't Diablo 2 and WarCraft 3 included in the last commit?

[HarpyWar]

Diablo 2 and Warcraft 3 use UTF-8 by default - no need to change encoding there.

[HarpyWar]

Localization is complete. Waiting for translations.