Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lines conencting stars #4

Open
shahmilav opened this issue Apr 7, 2022 · 3 comments
Open

Add lines conencting stars #4

shahmilav opened this issue Apr 7, 2022 · 3 comments
Labels
feature request New feature or request not doing This will not be worked on

Comments

@shahmilav
Copy link

shahmilav commented Apr 7, 2022

FEATURE REQUEST

First of all, thanks for this. It is super interesting and a great way to start a terminal session.

My only idea was that maybe the stars could be connected by lines in order to better see the constellation? This may not be practical considering everything is stored in JSON format, but maybe we could use images? Just an idea.

ORION CONSTELLATION
basic idea

@Haruno19
Copy link
Owner

Haruno19 commented Apr 7, 2022

Thank you for your support and suggestion!

As a design choice, I wanted to avoid using images, so that won't probably be the case.
Anyways, with che current JSON format it's possible to add other characters (such as box-drawing characters) to the graphs' data in order to draw the lines between the stars.

While designing starfetch, I purposely did not include lines because I thought it would have looked messy and "not clean", but I could definitely try to render graphs with lines, and, if they look good enough, maybe add it as an optional feature.

I'll probably try this later today.

@Haruno19 Haruno19 added feature request New feature or request work in progress Currently working on this labels Apr 7, 2022
@Haruno19
Copy link
Owner

Haruno19 commented Apr 8, 2022

A little update on this.
It's definitely not possibile to draw the lines with characters without breaking the proportion of the constellations.
I tried to look for a solution using images but It's really hard (if not impossible) to find a standard method to display images in the terminal. It will eventually come down to depend on external software, that may as well not be compatible with all terminal emulators + need specific configuration.
So, I'm really sorry but unless a simpler solution is found, I won't add this feature to starfetch any time soon.

I'll still keep this issue open but flag it as "not doing"

@Haruno19 Haruno19 added not doing This will not be worked on and removed work in progress Currently working on this labels Apr 8, 2022
@shahmilav
Copy link
Author

shahmilav commented Apr 9, 2022

Aah, I figured. I understand how this would not work. Anyway, thanks for the support and keep on improving starfetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request not doing This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants