Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(verification): remove verification dependencies from the verification process [part 8/12] #1023

Open
wants to merge 1 commit into
base: refactor/verification-dependencies-7
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 6, 2024

Depends on #1022


Motivation

This PR continues the work started in the previous PR, #1022. Read its description for more info. After this PR, all verification dependencies are externalized and pre-calculated.

Acceptance Criteria

  • Refactor reward lock methods to depend on functional parameters instead of a TransactionStorage.
  • Update VerificationService and verifiers to use verification models and dependencies instead of directly accessing a storage.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the refactor label May 6, 2024
@glevco glevco self-assigned this May 6, 2024
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from 7408bcf to 326d107 Compare May 6, 2024 20:51
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from 326d107 to aad0eab Compare May 7, 2024 00:45
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 91.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 84.66%. Comparing base (10e8be8) to head (8416913).

Files Patch % Lines
hathor/verification/transaction_verifier.py 77.77% 1 Missing and 3 partials ⚠️
hathor/verification/verification_service.py 92.85% 2 Missing and 2 partials ⚠️
hathor/verification/vertex_verifier.py 80.95% 2 Missing and 2 partials ⚠️
hathor/manager.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           refactor/verification-dependencies-7    #1023      +/-   ##
========================================================================
+ Coverage                                 84.46%   84.66%   +0.19%     
========================================================================
  Files                                       302      302              
  Lines                                     23151    23146       -5     
  Branches                                   3515     3515              
========================================================================
+ Hits                                      19555    19596      +41     
+ Misses                                     2917     2865      -52     
- Partials                                    679      685       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review May 7, 2024 03:11
@glevco glevco force-pushed the refactor/verification-dependencies-7 branch from 42f7cbf to 7a6d76d Compare May 8, 2024 03:06
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from aad0eab to f28c610 Compare May 8, 2024 03:07
@glevco glevco force-pushed the refactor/verification-dependencies-7 branch from 7a6d76d to e799dce Compare May 10, 2024 02:28
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from f28c610 to 5811a89 Compare May 10, 2024 02:31
@glevco glevco force-pushed the refactor/verification-dependencies-7 branch 2 times, most recently from 1782d6b to 3d4fb3e Compare May 10, 2024 02:51
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from 5811a89 to 3d42e7a Compare May 10, 2024 02:53
@glevco glevco force-pushed the refactor/verification-dependencies-7 branch from 3d4fb3e to 10e8be8 Compare May 13, 2024 14:31
@glevco glevco changed the title refactor(verification): remove verification dependencies from the verification process [part 8] refactor(verification): remove verification dependencies from the verification process [part 8/12] May 13, 2024
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from 3d42e7a to 8416913 Compare May 13, 2024 14:32
@glevco glevco force-pushed the refactor/verification-dependencies-7 branch 2 times, most recently from 044bd0b to 5f3632f Compare August 23, 2024 21:51
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from 8416913 to 62be7c0 Compare August 23, 2024 22:01
@glevco glevco force-pushed the refactor/verification-dependencies-7 branch from 5f3632f to 5222dfe Compare August 26, 2024 17:20
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from 62be7c0 to b5ecc17 Compare August 26, 2024 17:23
@glevco glevco force-pushed the refactor/verification-dependencies-8 branch from b5ecc17 to 7c88858 Compare August 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress (WIP)
Development

Successfully merging this pull request may close these issues.

None yet

1 participant