-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): remove verification dependencies from the verification process [part 8/12] #1023
Open
glevco
wants to merge
1
commit into
refactor/verification-dependencies-7
Choose a base branch
from
refactor/verification-dependencies-8
base: refactor/verification-dependencies-7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
May 6, 2024 20:51
7408bcf
to
326d107
Compare
1 task
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
May 7, 2024 00:45
326d107
to
aad0eab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/verification-dependencies-7 #1023 +/- ##
========================================================================
+ Coverage 84.46% 84.66% +0.19%
========================================================================
Files 302 302
Lines 23151 23146 -5
Branches 3515 3515
========================================================================
+ Hits 19555 19596 +41
+ Misses 2917 2865 -52
- Partials 679 685 +6 ☔ View full report in Codecov by Sentry. |
This was referenced May 7, 2024
glevco
force-pushed
the
refactor/verification-dependencies-7
branch
from
May 8, 2024 03:06
42f7cbf
to
7a6d76d
Compare
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
May 8, 2024 03:07
aad0eab
to
f28c610
Compare
glevco
force-pushed
the
refactor/verification-dependencies-7
branch
from
May 10, 2024 02:28
7a6d76d
to
e799dce
Compare
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
May 10, 2024 02:31
f28c610
to
5811a89
Compare
glevco
force-pushed
the
refactor/verification-dependencies-7
branch
2 times, most recently
from
May 10, 2024 02:51
1782d6b
to
3d4fb3e
Compare
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
May 10, 2024 02:53
5811a89
to
3d42e7a
Compare
glevco
force-pushed
the
refactor/verification-dependencies-7
branch
from
May 13, 2024 14:31
3d4fb3e
to
10e8be8
Compare
glevco
changed the title
refactor(verification): remove verification dependencies from the verification process [part 8]
refactor(verification): remove verification dependencies from the verification process [part 8/12]
May 13, 2024
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
May 13, 2024 14:32
3d42e7a
to
8416913
Compare
glevco
force-pushed
the
refactor/verification-dependencies-7
branch
2 times, most recently
from
August 23, 2024 21:51
044bd0b
to
5f3632f
Compare
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
August 23, 2024 22:01
8416913
to
62be7c0
Compare
glevco
force-pushed
the
refactor/verification-dependencies-7
branch
from
August 26, 2024 17:20
5f3632f
to
5222dfe
Compare
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
August 26, 2024 17:23
62be7c0
to
b5ecc17
Compare
…ification process
glevco
force-pushed
the
refactor/verification-dependencies-8
branch
from
August 26, 2024 17:25
b5ecc17
to
7c88858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1022
Motivation
This PR continues the work started in the previous PR, #1022. Read its description for more info. After this PR, all verification dependencies are externalized and pre-calculated.
Acceptance Criteria
TransactionStorage
.VerificationService
and verifiers to use verification models and dependencies instead of directly accessing a storage.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged