Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[display] nested pattern is not reporting CompletionModeKind.Pattern #7287

Closed
Gama11 opened this issue Jul 19, 2018 · 1 comment · Fixed by #7323
Closed

[display] nested pattern is not reporting CompletionModeKind.Pattern #7287

Gama11 opened this issue Jul 19, 2018 · 1 comment · Fixed by #7323
Labels
feature-ide IDE / Editor support

Comments

@Gama11
Copy link
Member

Gama11 commented Jul 19, 2018

kind is 2 there (regular Toplevel).

import haxe.macro.Expr.ExprDef;

class Main {
	public static function main() {
		switch ((null:ExprDef)) {
			case EConst():
			case _:
		}
	}
}

This means vshaxe can't auto-generate the arguments like it does for the outer EConst.

@markknol markknol added the feature-ide IDE / Editor support label Jul 26, 2018
@Gama11
Copy link
Member Author

Gama11 commented Jul 29, 2018

Ah, actually, simply reporting Pattern in that case wouldn't do, as we would then try to auto-insert : and have the same issue as with #7223.

Gama11 added a commit to Gama11/haxe that referenced this issue Jul 30, 2018
Simn pushed a commit that referenced this issue Jul 30, 2018
* [display] add isOutermostPattern to CRPattern

closes #7287

* fix encoding
Gama11 added a commit to vshaxe/haxe-language-server that referenced this issue Jul 30, 2018
kLabz pushed a commit to kLabz/haxe-languageserver that referenced this issue Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-ide IDE / Editor support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants